Limit read of well-known file #13

Merged

Jade merged 5 commits from zoe/limit-well-known-read into main 2026-06-26 22:04:18 +00:00

Conversation 4 Commits 5 Files changed 4 +681 -14

s1lv3r commented 2026-06-23 00:37:27 +00:00

Member

Copy link

Recreation of #10 since it decided to close itself and break.

Depends on #11 (#12)

Todo:

• Tests

Recreation of #10 since it decided to close itself and break. Depends on #11 (#12) Todo: - [x] Tests

s1lv3r self-assigned this 2026-06-23 00:37:27 +00:00

s1lv3r added 3 commits 2026-06-23 00:37:27 +00:00

refactor: Move to builder pattern ... f581cf166c

Note that the original methods still exist, but are marked as deprecated

chore: Formatting 18bfbb7df0

feat: Limit read of well-known file 75c211b3cc

s1lv3r added a new dependency 2026-06-23 00:37:38 +00:00

#12 Move to builder pattern and split up library

s1lv3r force-pushed zoe/limit-well-known-read from 75c211b3cc to 68e3b18118 2026-06-23 21:40:28 +00:00 Compare

s1lv3r changed title from WIP: Limit read of well-known file to Limit read of well-known file 2026-06-23 21:40:57 +00:00

s1lv3r requested review from Jade 2026-06-23 21:41:00 +00:00

s1lv3r added 1 commit 2026-06-23 23:06:05 +00:00

fix: fmt a3531989fc

s1lv3r added 1 commit 2026-06-23 23:10:57 +00:00

fix: Return proper error if well-known too large 0cd62ec1bb

s1lv3r changed title from Limit read of well-known file to WIP: Limit read of well-known file 2026-06-23 23:12:37 +00:00

s1lv3r added 1 commit 2026-06-24 18:15:17 +00:00

chore: Add tests e03ca33326

s1lv3r changed title from WIP: Limit read of well-known file to Limit read of well-known file 2026-06-24 18:16:36 +00:00

s1lv3r added 1 commit 2026-06-24 18:27:00 +00:00

fix: Change default to not accept invalid certs 5b350f4885

s1lv3r added 1 commit 2026-06-24 18:33:14 +00:00

refactor: Simplify structure for limit_read 013b764d55

s1lv3r added 1 commit 2026-06-24 18:34:39 +00:00

chore: formatting 61ed59684d

s1lv3r added 1 commit 2026-06-24 19:22:06 +00:00

fix: Log error when request fails 7b03668037

s1lv3r added 1 commit 2026-06-24 19:31:03 +00:00

chore: Update readme ... 0739f32fee

installed+ran prek and cargo-readme

s1lv3r commented 2026-06-24 19:34:24 +00:00

Author

Member

Copy link

ok so the tests are failing because the container cant resolve localhost as a domain

they work fine on any properly setup system, idk how to fix that error

ok so the tests are failing because the container cant resolve localhost as a domain they work fine on any properly setup system, idk how to fix that error

Jade force-pushed zoe/limit-well-known-read from 0739f32fee to 680758697b 2026-06-26 19:14:33 +00:00 Compare

Jade force-pushed zoe/limit-well-known-read from 680758697b to 17074e2617 2026-06-26 19:18:11 +00:00 Compare

Jade force-pushed zoe/limit-well-known-read from 17074e2617 to 06da83c134 2026-06-26 19:19:58 +00:00 Compare

Jade force-pushed zoe/limit-well-known-read from 06da83c134 to 9ae7a46637 2026-06-26 19:22:05 +00:00 Compare

Jade force-pushed zoe/limit-well-known-read from 9ae7a46637 to f7a5fd8198 2026-06-26 19:22:46 +00:00 Compare

Jade commented 2026-06-26 19:24:04 +00:00

Owner

Copy link

test_invalid_well_known fails on my machine, on macos, as well. All others pass, though

test_invalid_well_known fails on my machine, on macos, as well. All others pass, though

Jade force-pushed zoe/limit-well-known-read from f7a5fd8198 to 4010519745 2026-06-26 19:29:16 +00:00 Compare

Jade force-pushed zoe/limit-well-known-read from 4010519745 to 81773475b3 2026-06-26 19:32:25 +00:00 Compare

Jade added 1 commit 2026-06-26 19:57:34 +00:00

feat: Use parking_lot 5d843c1754

Jade force-pushed zoe/limit-well-known-read from 5d843c1754 to 81773475b3 2026-06-26 20:01:26 +00:00 Compare

s1lv3r commented 2026-06-26 20:11:26 +00:00

Author

Member

Copy link

Probably happens due to the localhost.localhost, which i believe is technically supposed to resolve everywhere i think? i guess not

Probably happens due to the `localhost.localhost`, which i believe is technically supposed to resolve everywhere i think? i guess not

Jade force-pushed zoe/limit-well-known-read from 81773475b3 to 9cbef6e16f 2026-06-26 20:31:52 +00:00 Compare

Jade added 1 commit 2026-06-26 21:49:23 +00:00

fix: Use more compatible localhost domain f493f480ed

Jade approved these changes 2026-06-26 22:03:57 +00:00

Jade merged commit f493f480ed into main 2026-06-26 22:04:18 +00:00

s1lv3r referenced this pull request 2026-06-26 22:13:20 +00:00

Limit read of well-known files #1

s1lv3r deleted branch zoe/limit-well-known-read 2026-07-08 16:35:08 +00:00

Sign in to join this conversation.

Reviewers

No reviewers

Jade

Labels

Clear labels

No items

No labels

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

s1lv3r

2 participants

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Depends on

#12 Move to builder pattern and split up library

continuwuation/resolvematrix

Reference

continuwuation/resolvematrix!13

No description provided.