continuwuation/continuwuity
continuwuation/continuwuity
12
46
Fork 42
Code Issues 97 Pull requests 22 Releases 24 Packages 3 Activity Actions

feat: Ignore ACLs that deny everyone #1294

Closed
nex wants to merge 2 commits from nex/feat/ignore-deny-all-acls into main
pull from: nex/feat/ignore-deny-all-acls
merge into: continuwuation:main
Conversation 4 Commits 2 Files changed 1 +2 -4
nex commented 2026-01-15 12:32:31 +00:00
Owner
Copy link

This pull request ignores deny: * ACL rules, they're hardly used for legitimate purposes and namely just brick rooms, intentionally or not.
This disobeys the spec on ACLs but frankly the spec is stupid so that's fine.

This also breaks allow-only ACLs but nobody uses those

Pull request checklist:

  • This pull request targets the main branch, and the branch is named something other than
    main.
  • I have written an appropriate pull request title and my description is clear.
  • I understand I am responsible for the contents of this pull request.
  • I have followed the contributing guidelines:
<!-- In order to help reviewers know what your pull request does at a glance, you should ensure that 1. Your PR title is a short, single sentence describing what you changed 2. You have described in more detail what you have changed, why you have changed it, what the intended effect is, and why you think this will be beneficial to the project. If you have made any potentially strange/questionable design choices, but didn't feel they'd benefit from code comments, please don't mention them here - after opening your pull request, go to "files changed", and click on the "+" symbol in the line number gutter, and attach comments to the lines that you think would benefit from some clarification. --> This pull request ignores `deny: *` ACL rules, they're hardly used for legitimate purposes and namely just brick rooms, intentionally or not. This disobeys the spec on ACLs but frankly the spec is stupid so that's fine. This also breaks allow-only ACLs but nobody uses those <!-- Example: This pull request allows us to warp through time and space ten times faster than before by double-inverting the warp drive with hyperheated jump fluid, both making the drive faster and more efficient. This resolves the common issue where we have to wait more than 10 milliseconds to engage, use, and disengage the warp drive when travelling between galaxies. --> <!-- Closes: #... --> <!-- Fixes: #... --> <!-- Uncomment the above line(s) if your pull request fixes an issue or closes another pull request by superseding it. Replace `#...` with the issue/pr number, such as `#123`. --> **Pull request checklist:** <!-- You need to complete these before your PR can be considered. If you aren't sure about some, feel free to ask for clarification in #dev:continuwuity.org. --> - [x] This pull request targets the `main` branch, and the branch is named something other than `main`. - [x] I have written an appropriate pull request title and my description is clear. - [x] I understand I am responsible for the contents of this pull request. - I have followed the [contributing guidelines][c1]: - [x] My contribution follows the [code style][c2], if applicable. - [x] I ran [pre-commit checks][c1pc] before opening/drafting this pull request. - [ ] I have [tested my contribution][c1t] (or proof-read it for documentation-only changes) myself, if applicable. This includes ensuring code compiles. - [x] My commit messages follow the [commit message format][c1cm] and are descriptive. - [ ] I have written a [news fragment][n1] for this PR, if applicable<!--(can be done after hitting open!)-->. <!-- Notes on these requirements: - While not required, we encourage you to sign your commits with GPG or SSH to attest the authenticity of your changes. - While we allow LLM-assisted contributions, we do not appreciate contributions that are low quality, which is typical of machine-generated contributions that have not had a lot of love and care from a human. Please do not open a PR if all you have done is asked ChatGPT to tidy up the codebase with a +-100,000 diff. - In the case of code style violations, reviewers may leave review comments/change requests indicating what the ideal change would look like. For example, a reviewer may suggest you lower a log level, or use `match` instead of `if/else` etc. - In the case of code style violations, pre-commit check failures, minor things like typos/spelling errors, and in some cases commit format violations, reviewers may modify your branch directly, typically by making changes and adding a commit. Particularly in the latter case, a reviewer may rebase your commits to squash "spammy" ones (like "fix", "fix", "actually fix"), and reword commit messages that don't satisfy the format. - Pull requests MUST pass the `Checks` CI workflows to be capable of being merged. This can only be bypassed in exceptional circumstances. If your CI flakes, let us know in matrix:r/dev:continuwuity.org. - Pull requests have to be based on the latest `main` commit before being merged. If the main branch changes while you're making your changes, you should make sure you rebase on main before opening a PR. Your branch will be rebased on main before it is merged if it has fallen behind. - We typically only do fast-forward merges, so your entire commit log will be included. Once in main, it's difficult to get out cleanly, so put on your best dress, smile for the cameras! --> [c1]: https://forgejo.ellis.link/continuwuation/continuwuity/src/branch/main/CONTRIBUTING.md [c2]: https://forgejo.ellis.link/continuwuation/continuwuity/src/branch/main/docs/development/code_style.mdx [c1pc]: https://forgejo.ellis.link/continuwuation/continuwuity/src/branch/main/CONTRIBUTING.md#pre-commit-checks [c1t]: https://forgejo.ellis.link/continuwuation/continuwuity/src/branch/main/CONTRIBUTING.md#running-tests-locally [c1cm]: https://forgejo.ellis.link/continuwuation/continuwuity/src/branch/main/CONTRIBUTING.md#commit-messages [n1]: https://towncrier.readthedocs.io/en/stable/tutorial.html#creating-news-fragments
feat: Ignore ACLs that deny everyone
Some checks failed
Documentation / Build and Deploy Documentation (pull_request) Successful in 1m6s
Details
Checks / Prek / Pre-commit & Formatting (pull_request) Has been cancelled
Details
Checks / Prek / Clippy and Cargo Tests (pull_request) Has been cancelled
Details
40ac1a49d0
feat: Fully ignore ACLs that deny everyone
Some checks failed
Documentation / Build and Deploy Documentation (pull_request) Successful in 56s
Details
Checks / Prek / Pre-commit & Formatting (pull_request) Successful in 2m1s
Details
Checks / Prek / Clippy and Cargo Tests (pull_request) Failing after 17m39s
Details
63c2848ac0
nex 2026-01-15 12:35:47 +00:00
Jade reviewed 2026-01-15 12:42:39 +00:00
src/service/rooms/event_handler/acl_check.rs
@ -29,3 +28,1 @@
&& acl_event_content.allow.contains(&String::from("*"))
{
warn!(%room_id, "Ignoring broken ACL event (allow key and deny key both contain wildcard \"*\"");
if acl_event_content.deny.contains(&String::from("*")) || acl_event_content.deny.is_empty() {
Jade commented 2026-01-15 12:42:39 +00:00
Owner
Copy link

Breaking allow-only ACLs is probably bad? A better heuristic might be if it bans the server itself, ignore it

Breaking allow-only ACLs is probably bad? A better heuristic might be if it bans the server itself, ignore it
nex commented 2026-01-15 12:44:02 +00:00
Author
Owner
Copy link

Ignoring a self-ban is a no-op (since other servers still then won't accept the events), breaking allow-only ACLs is fine

Ignoring a self-ban is a no-op (since other servers still then won't accept the events), breaking allow-only ACLs is fine
Jade commented 2026-01-15 12:46:00 +00:00
Owner
Copy link

No as in if it's a self-ban ignore the whole ACL, so if a ban hits all servers it's ignored by all servers, but it still works as expected if that's intentional for the servers intended to be in the room

No as in if it's a self-ban ignore the whole ACL, so if a ban hits all servers it's ignored by all servers, but it still works as expected if that's intentional for the servers intended to be in the room
Jade commented 2026-01-15 12:46:26 +00:00
Owner
Copy link

although that has the issue of effectively room splitting in some cases?

although that has the issue of effectively room splitting in some cases?
nex closed this pull request 2026-01-15 13:58:54 +00:00
nex deleted branch nex/feat/ignore-deny-all-acls 2026-01-15 14:28:46 +00:00
crispycat commented 2026-01-22 04:39:40 +00:00
First-time contributor
Copy link

This seems like a bad idea—it deviates from spec, prevents its use in legitimate cases (such as using it to help take down rooms with CSAM) and Synapse and such will continue to use it anyway

This seems like a bad idea—it deviates from spec, prevents its use in legitimate cases (such as using it to help take down rooms with CSAM) and Synapse and such will continue to use it anyway
nex commented 2026-01-22 12:11:21 +00:00
Author
Owner
Copy link

Yeah, that's why it was closed. Although I'll say deviating from the spec is fine if the spec is stupid, which ACLs are.

Yeah, that's why it was closed. Although I'll say deviating from the spec is fine if the spec is stupid, which ACLs are.
Jade commented 2026-01-22 12:31:22 +00:00
Owner
Copy link

Ignoring self bans (so ones that ban the sender) would still allow you to destroy the room in that case - you just send an ACL that doesn't selfban, and then ban/takedown the room on the server to fully kill it

Ignoring self bans (so ones that ban the sender) would still allow you to destroy the room in that case - you just send an ACL that doesn't selfban, and then ban/takedown the room on the server to fully kill it
Some checks failed
Documentation / Build and Deploy Documentation (pull_request) Successful in 56s
Details
Checks / Prek / Pre-commit & Formatting (pull_request) Successful in 2m1s
Required
Details
Checks / Prek / Clippy and Cargo Tests (pull_request) Failing after 17m39s
Required
Details

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No reviewers
continuwuation/Owners
Labels
Clear labels   
Blocked

This pull request or issue is currently blocked from being merged/closed

  
Bug

Something isn't working as intended

  
Cherry-picking

Commits picked from other conduit projects

  
Database

This requires or includes changes to the database

  
Dependencies

Something dependency related

  
Dependencies/Renovate

Automatic dependency upgrades by Renovate

  
Difficulty
Easy
Low difficulty to implement - touches few parts of the codebase, low complexity

  
Difficulty
Hard
High difficulty to implement - touches many parts of the codebase, high complexity

  
Difficulty
Medium
Medium difficulty to implement - touches more parts of the codebase, higher complexity

  
Documentation

Improvements or additions to documentation

  
Enhancement

New feature or request

  
Good first issue

Good for newcomers

  
Help wanted

Additional eyes and keyboards are required for this one

  
Inherited

Issues that have been inhereted from the project pre-fork

  
Matrix/Administration

Features pertaining to homeserver administration

  
Matrix/Appservices

Features pertaining to the appservice API

  
Matrix/Auth

Features pertaining to authentication

  
Matrix/Client

Features pertaining to client-to-server interactions

  
Matrix/Core

Issues relating to core matrix functionality, such as state resolution and PDU formats

  
Matrix/Federation

Features pertaining to server-to-server interactions

  
Matrix/Hydra

Issues related to room version 12 and related changes (temporary label)

  
Matrix/MSC

Features pertaining to unstable matrix features

  
Matrix/Media

Features pertaining to media interactions

  
Meta

Related to housekeeping, maintenance, or other repo-meta.

  
Meta/CI

Issues related to CI changes

  
Meta/Packaging

Packaging

  
Priority
Blocking
This issue is blocking the next release

  
Priority
High
This issue is very important

  
Priority
Low
This issue is of a rather low priority

  
Security

This item is related to general security

  
Status
Confirmed
This issue has enough information and is confirmed

  
Status
Duplicate
This issue or pull request already exists

  
Status
Invalid
This issue doesn't seem right

  
Status
Needs Investigation
This issue needs further investigation

  
Support

Questions or support requests

  
To-Merge

   
Wont fix

This will not be worked on

  
old/ci/cd

Ci/CD

Archived

  
old/rust

Pull requests that update Rust code

Archived

No labels
Blocked
Bug
Cherry-picking
Database
Dependencies
Dependencies/Renovate
Difficulty
Easy
Difficulty
Hard
Difficulty
Medium
Documentation
Enhancement
Good first issue
Help wanted
Inherited
Matrix/Administration
Matrix/Appservices
Matrix/Auth
Matrix/Client
Matrix/Core
Matrix/Federation
Matrix/Hydra
Matrix/MSC
Matrix/Media
Meta
Meta/CI
Meta/Packaging
Priority
Blocking
Priority
High
Priority
Low
Security
Status
Confirmed
Status
Duplicate
Status
Invalid
Status
Needs Investigation
Support
To-Merge
Wont fix
old/ci/cd
old/rust
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
continuwuation/continuwuity!1294
No description provided.