fix(!1416, !1415): Remove ability to set rocksdb as read only #1418

Merged
Jade merged 3 commits from Terryiscool160/continuwuity:terry/remove-read-only into main 2026-02-18 23:11:54 +00:00
Contributor

removes the ability to set rocksdb as read only. realistically, there isnt much use to this
and it seems to cause much more harm than it is really worth

Fixes: #1416, #1415

Pull request checklist:

  • This pull request targets the main branch, and the branch is named something other than
    main.
  • I have written an appropriate pull request title and my description is clear.
  • I understand I am responsible for the contents of this pull request.
  • I have followed the contributing guidelines:
removes the ability to set rocksdb as read only. realistically, there isnt much use to this and it seems to cause much more harm than it is really worth Fixes: #1416, #1415 **Pull request checklist:** - [x] This pull request targets the `main` branch, and the branch is named something other than `main`. - [x] I have written an appropriate pull request title and my description is clear. - [x] I understand I am responsible for the contents of this pull request. - I have followed the [contributing guidelines][c1]: - [x] My contribution follows the [code style][c2], if applicable. - [x] I ran [pre-commit checks][c1pc] before opening/drafting this pull request. - [x] I have [tested my contribution][c1t] (or proof-read it for documentation-only changes) myself, if applicable. This includes ensuring code compiles. - [x] My commit messages follow the [commit message format][c1cm] and are descriptive. - [x] I have written a [news fragment][n1] for this PR, if applicable [c1]: https://forgejo.ellis.link/continuwuation/continuwuity/src/branch/main/CONTRIBUTING.md [c2]: https://forgejo.ellis.link/continuwuation/continuwuity/src/branch/main/docs/development/code_style.mdx [c1pc]: https://forgejo.ellis.link/continuwuation/continuwuity/src/branch/main/CONTRIBUTING.md#pre-commit-checks [c1t]: https://forgejo.ellis.link/continuwuation/continuwuity/src/branch/main/CONTRIBUTING.md#running-tests-locally [c1cm]: https://forgejo.ellis.link/continuwuation/continuwuity/src/branch/main/CONTRIBUTING.md#commit-messages [n1]: https://towncrier.readthedocs.io/en/stable/tutorial.html#creating-news-fragments
fix: Remove ability to set rocksdb as read only
Some checks failed
Documentation / Build and Deploy Documentation (pull_request) Has been skipped
Checks / Prek / Pre-commit & Formatting (pull_request) Successful in 1m51s
Checks / Prek / Clippy and Cargo Tests (pull_request) Has been cancelled
735aaf5a84
Terryiscool160 changed title from fix: Remove ability to set rocksdb as read only to fix(!1416, !1415): Remove ability to set rocksdb as read only 2026-02-18 22:49:27 +00:00
docs: Changelog
Some checks failed
Documentation / Build and Deploy Documentation (pull_request) Has been skipped
Checks / Prek / Pre-commit & Formatting (pull_request) Successful in 2m1s
Checks / Prek / Clippy and Cargo Tests (pull_request) Has been cancelled
fc27d0f430
fix: Remove rocksdb secondary mode
Some checks failed
Documentation / Build and Deploy Documentation (pull_request) Has been skipped
Checks / Prek / Pre-commit & Formatting (pull_request) Failing after 3m6s
Checks / Prek / Clippy and Cargo Tests (pull_request) Successful in 30m48s
6c2743164d
Jade approved these changes 2026-02-18 23:08:36 +00:00
ginger approved these changes 2026-02-18 23:09:31 +00:00
ginger left a comment
Owner

ship it

ship it
Jade merged commit 7ecac93ddc into main 2026-02-18 23:11:54 +00:00
Owner

hippity hoppity your signatures are – gone :3

hippity hoppity your signatures are – gone :3
Terryiscool160 deleted branch terry/remove-read-only 2026-02-18 23:14:02 +00:00
ginger added this to the next milestone 2026-02-20 14:10:21 +00:00
Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
continuwuation/continuwuity!1418
No description provided.