WIP: feat: refactor the service manager to achieve 30x faster server initialization #1482

gamesguru · 2026-03-03T07:22:56Z

gamesguru commented

2026-03-03 07:22:56 +00:00

Refactor the service manager to achieve 30x faster server initialization and avoiding full database scans by implementing index-aware presence resets on a background thread.

And fix the shutdown manager by terminating workers in the correct order of their dependency hierarchy, thereby preventing shutdown hangs and resulting in an extremely fast shutdown sequence which gives special preference only to the RocksDB worker and the integrity of the database.

Pull request checklist:

This pull request targets the main branch, and the branch is named something other than
main.
I have written an appropriate pull request title and my description is clear.
I understand I am responsible for the contents of this pull request.
I have followed the [contributing guidelines][c1]:
- My contribution follows the [code style][c2], if applicable.
- I ran [pre-commit checks][c1pc] before opening/drafting this pull request.
- I have [tested my contribution][c1t] (or proof-read it for documentation-only changes)
  myself, if applicable. This includes ensuring code compiles.
- My commit messages follow the [commit message format][c1cm] and are descriptive.
- I have written a [news fragment][n1] for this PR, if applicable.

Refactor the service manager to achieve 30x faster server initialization and avoiding full database scans by implementing index-aware presence resets on a background thread. And fix the shutdown manager by terminating workers in the correct order of their dependency hierarchy, thereby preventing shutdown hangs and resulting in an extremely fast shutdown sequence which gives special preference only to the RocksDB worker and the integrity of the database. **Pull request checklist:**  - [x] This pull request targets the `main` branch, and the branch is named something other than `main`. - [x] I have written an appropriate pull request title and my description is clear. - [x] I understand I am responsible for the contents of this pull request. - I have followed the [contributing guidelines][c1]: - [x] My contribution follows the [code style][c2], if applicable. - [x] I ran [pre-commit checks][c1pc] before opening/drafting this pull request. - [x] I have [tested my contribution][c1t] (or proof-read it for documentation-only changes) myself, if applicable. This includes ensuring code compiles. - [x] My commit messages follow the [commit message format][c1cm] and are descriptive. - [x] I have written a [news fragment][n1] for this PR, if applicable.

gamesguru added 12 commits

2026-03-03 07:22:56 +00:00

feat: efforts to debug/resolve sluggish startup tendencies 45ca3925b5

fix: missing logic inversion for acquired keys (should speed up room joins) 8cd60f5878

fix: shut the services down in a logical, safer, and more expeditious manner b28f883e0f

feat: parallelize DB opening, improve warn log. 4a8eca27d0

fix: shutdown cleanup logic d353fc0e6c

fix: attempt to completely safely close hanging database handlers/refs 7f4dab9482

fix better handling of shutdown logic and closure of database references e872bcdfed

fix: PresenceService leak, which should release hold on GlobalsService and DB 5969e87206

fix: adjust log levels 221776973a

fix: add additional info around warning log "Missing Authorization header.: Header of type authorization was missing" b3e4f9d97e

fix: restrict startup presence reset to local users 9518cc7b30

fix: lint warnings from my branch and main

Documentation / Build and Deploy Documentation (pull_request) Has been skipped

Details

Checks / Prek / Pre-commit & Formatting (pull_request) Failing after 3m0s

Details

Checks / Prek / Clippy and Cargo Tests (pull_request) Successful in 20m58s

Details

1ce0ffbaed

gamesguru added 3 commits

2026-03-03 07:59:02 +00:00

perf: allow 3 concurrent DNS lookups per request (no more sequential SRV->A->AAAA bottlenecks) ab63a15e0c

style: improve loggings of parallel DNS timeouts if admins care to know e018b9ae5b

fix: restore less ominous warning log from guru/nightly

Documentation / Build and Deploy Documentation (pull_request) Has been skipped

Details

Checks / Prek / Pre-commit & Formatting (pull_request) Successful in 3m44s

Details

Checks / Prek / Clippy and Cargo Tests (pull_request) Successful in 21m36s

Details

6a4f968f5f

gamesguru changed title from ~~Refactor the service manager to achieve 30x faster server initialization~~ to feat: refactor the service manager to achieve 30x faster server initialization

2026-03-03 08:47:50 +00:00

julian45 reviewed

2026-03-03 12:19:05 +00:00

src/api/client/account_data.rs

					
				@ -10,3 +10,3 @@

					events::{

						AnyGlobalAccountDataEventContent, AnyRoomAccountDataEventContent,

						GlobalAccountDataEventType, RoomAccountDataEventType,

						RoomAccountDataEventType,

FWIW, I believe this change is covered by #1479, so you may want to rebase depending on the outcome of that one.

gamesguru marked this conversation as resolved

Jade changed title from ~~feat: refactor the service manager to achieve 30x faster server initialization~~ to WIP: feat: refactor the service manager to achieve 30x faster server initialization

2026-03-03 18:32:36 +00:00

gamesguru added 1 commit

2026-03-04 17:50:15 +00:00

Merge branch 'main' into guru/fix/cli-optimization/faster-startup-safer-shutdown

Documentation / Build and Deploy Documentation (pull_request) Has been skipped

Details

Checks / Prek / Pre-commit & Formatting (pull_request) Successful in 4m19s

Details

Checks / Prek / Clippy and Cargo Tests (pull_request) Failing after 36m19s

Details

de9b531955

gamesguru commented

2026-03-04 18:56:41 +00:00

Commits affecting the below files will be removed to other branches. It is advised to use the git CLI when reviewing my PRs, especially large ones.

# setup
git remote add ellis-gg https://forgejo.ellis.link/gamesguru/continuwuity.git
git fetch --all

# configure lgb alias in .gitconfig
git config --global alias.lgb "log --graph --pretty=format:'%Cred%h%Creset -%C(yellow)%d%Creset %s %Cgreen(%cr) %C(bold blue)<%aN>%Creset%n' --abbrev-commit --date=relative"

# view raw branch history
git lgb ellis-gg/guru/fix/cli-optimization/faster-startup-safer-shutdown

# view full diff against main (using '...' to see changes Diverged from main)
git diff origin/main...ellis-gg/guru/fix/cli-optimization/faster-startup-safer-shutdown

# view diff excluding the undesired files
IGNORE_FILES_LIST=(
  src/api/router/auth.rs
  src/api/server/utils.rs
  src/core/config/mod.rs
  src/database/engine/db_opts.rs
  src/service/resolver/actual.rs
  src/service/resolver/dns.rs
  src/service/server_keys/acquire.rs
)
IGNORE="${IGNORE_FILES_LIST[@]/#/:^}"

git diff origin/main...ellis-gg/guru/fix/cli-optimization/faster-startup-safer-shutdown -- $IGNORE
# "stat" only diff (+/- count per file)
git diff --stat origin/main...ellis-gg/guru/fix/cli-optimization/faster-startup-safer-shutdown -- $IGNORE

Commits affecting the below files will be removed to other branches. It is advised to use the `git` CLI when reviewing my PRs, especially large ones. ```shell # setup git remote add ellis-gg https://forgejo.ellis.link/gamesguru/continuwuity.git git fetch --all # configure lgb alias in .gitconfig git config --global alias.lgb "log --graph --pretty=format:'%Cred%h%Creset -%C(yellow)%d%Creset %s %Cgreen(%cr) %C(bold blue)<%aN>%Creset%n' --abbrev-commit --date=relative" # view raw branch history git lgb ellis-gg/guru/fix/cli-optimization/faster-startup-safer-shutdown # view full diff against main (using '...' to see changes Diverged from main) git diff origin/main...ellis-gg/guru/fix/cli-optimization/faster-startup-safer-shutdown # view diff excluding the undesired files IGNORE_FILES_LIST=( src/api/router/auth.rs src/api/server/utils.rs src/core/config/mod.rs src/database/engine/db_opts.rs src/service/resolver/actual.rs src/service/resolver/dns.rs src/service/server_keys/acquire.rs ) IGNORE="${IGNORE_FILES_LIST[@]/#/:^}" git diff origin/main...ellis-gg/guru/fix/cli-optimization/faster-startup-safer-shutdown -- $IGNORE # "stat" only diff (+/- count per file) git diff --stat origin/main...ellis-gg/guru/fix/cli-optimization/faster-startup-safer-shutdown -- $IGNORE ```